Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid passing an identity function to createSelector #3931

Merged
merged 3 commits into from Dec 1, 2023

Conversation

EskiMojo14
Copy link
Collaborator

fixes #3930

Copy link

codesandbox bot commented Dec 1, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit f3736dc
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/656a0449444779000703ef28
😎 Deploy Preview https://deploy-preview-3931--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented Dec 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f3736dc:

Sandbox Source
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@christopherschroer
Copy link

@EskiMojo14 It seems the issue is still there for some tests.

https://github.com/reduxjs/redux-toolkit/actions/runs/7062008022/job/19224920674?pr=3931

@EskiMojo14
Copy link
Collaborator Author

yeah, super odd 😕

@EskiMojo14
Copy link
Collaborator Author

found it - useQuery passes noPendingQueryStateSelector as a default selector, but it's technically an identity function except if the selected state is uninitialised

this is good enough reason to disable the check in this case, i think - ultimately an identity function for selectFromResult isn't going to be the end of the world

@markerikson markerikson merged commit f0cd85d into v2.0-integration Dec 1, 2023
43 checks passed
@markerikson markerikson deleted the avoid-id-func branch December 1, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants