Fix bad transpilation of set iteration breaking invalidation #1020
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS seems to be transpiling a
for..of
Set iteration the wrong way - it's producing afor(let i
loop over_values.length
, which doesn't exist.Working around this by creating an Array from the Set values and looping over that.
Also tweaked the build setup to try having ESBuild do most of the transpilation instead of TS. (Doesn't fix the problem here, because ESBuild only goes down to ES2015, and it's an ES2015->ES5 step that's breaking.)