Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad transpilation of set iteration breaking invalidation #1020

Merged
merged 4 commits into from Apr 26, 2021

Conversation

markerikson
Copy link
Collaborator

TS seems to be transpiling a for..of Set iteration the wrong way - it's producing a for(let i loop over _values.length, which doesn't exist.

Working around this by creating an Array from the Set values and looping over that.

Also tweaked the build setup to try having ESBuild do most of the transpilation instead of TS. (Doesn't fix the problem here, because ESBuild only goes down to ES2015, and it's an ES2015->ES5 step that's breaking.)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 26, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1790b48:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration

@netlify
Copy link

netlify bot commented Apr 26, 2021

Deploy preview for redux-starter-kit-docs ready!

Built with commit 1790b48

https://deploy-preview-1020--redux-starter-kit-docs.netlify.app

@github-actions
Copy link

github-actions bot commented Apr 26, 2021

Size Change: +621 B (0%)

Total Size: 507 kB

Filename Size Change
dist/query/react/rtk-query-react.cjs.development.js 15.7 kB -75 B (0%)
dist/query/react/rtk-query-react.cjs.production.min.js 9.91 kB -98 B (-1%)
dist/query/react/rtk-query-react.esm.js 15.3 kB -32 B (0%)
dist/query/react/rtk-query-react.modern.development.js 12.4 kB +83 B (+1%)
dist/query/react/rtk-query-react.modern.js 12.4 kB +84 B (+1%)
dist/query/react/rtk-query-react.modern.production.min.js 8.1 kB +5 B (0%)
dist/query/react/rtk-query-react.umd.js 186 kB -34 B (0%)
dist/query/react/rtk-query-react.umd.min.js 61.5 kB -103 B (0%)
dist/query/rtk-query.cjs.development.js 13 kB -62 B (0%)
dist/query/rtk-query.cjs.production.min.js 8.24 kB -96 B (-1%)
dist/query/rtk-query.esm.js 12.6 kB -27 B (0%)
dist/query/rtk-query.modern.development.js 10.2 kB +134 B (+1%)
dist/query/rtk-query.modern.js 10.2 kB +131 B (+1%)
dist/query/rtk-query.modern.production.min.js 6.6 kB +28 B (0%)
dist/query/rtk-query.umd.js 25.4 kB +15 B (0%)
dist/query/rtk-query.umd.min.js 14.8 kB -93 B (-1%)
dist/redux-toolkit.cjs.development.js 11.9 kB +51 B (0%)
dist/redux-toolkit.cjs.production.min.js 5.76 kB -25 B (0%)
dist/redux-toolkit.esm.js 11.5 kB +92 B (+1%)
dist/redux-toolkit.modern.development.js 9.44 kB +223 B (+2%)
dist/redux-toolkit.modern.js 9.48 kB +221 B (+2%)
dist/redux-toolkit.modern.production.min.js 4.46 kB +134 B (+3%)
dist/redux-toolkit.umd.js 21.8 kB +78 B (0%)
dist/redux-toolkit.umd.min.js 10.6 kB -13 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/index.js 146 B 0 B
dist/query/index.js 144 B 0 B
dist/query/react/index.js 149 B 0 B

compressed-size-action

@markerikson markerikson merged commit 220534f into feature/v1.6-integration Apr 26, 2021
@markerikson markerikson deleted the bugfix/invalidation-loop branch April 26, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant