Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TINY FIX] Improve badge display in readme #263

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

aholachek
Copy link
Contributor

Before:

Screen Shot 2019-11-24 at 9 38 51 AM

After:

Screen Shot 2019-11-24 at 9 43 43 AM

@markerikson
Copy link
Collaborator

Ah, that explains why it wasn't showing up. Yeah, there's that bit of a dichotomy between the package name and the repo name, and that was causing me problems.

Thanks!

@markerikson
Copy link
Collaborator

OH WOW! I didn't even look at who was filing this PR at first.

I just wanted to say that your talk at ReactConf was AMAZING!!!

I don't do any kind of animation work or design stuff myself, but your presentation was fantastic! You packed a ton of practical info and examples into that talk, and it was fascinating to look at the examples.

Out of curiosity, what are you doing with RTK?

@markerikson markerikson merged commit 5eb1cc7 into reduxjs:master Nov 24, 2019
@aholachek
Copy link
Contributor Author

aholachek commented Nov 25, 2019

I’m glad you liked the talk! I am not using redux-toolkit yet but I was reading the tutorials in preparation for possibly refactoring our app at work to use it. The documentation is extremely good. (I really appreciated the “Redux Styleguide” you recently published as well).
I know the trend right now is to move logic inside of React components with hooks, but I feel like for me, keeping view logic separate from application logic is important for keeping an app easy to reason about and easy to update as it grows. So I’m really glad that to see how redux-toolkit reduces a lot of the cognitive load of using redux and hopefully makes it a more attractive option to use.

@markerikson
Copy link
Collaborator

You're welcome! And yeah, please let me know if you've got any feedback on using RTK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants