Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Default export of the module has or is using private name type error when using latest alpha/beta #3605

Merged
merged 1 commit into from Aug 26, 2023
Merged

fix: Default export of the module has or is using private name type error when using latest alpha/beta #3605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 8 additions & 9 deletions packages/toolkit/src/createSlice.ts
View file
Open in desktop
Expand Up @@ -233,15 +233,14 @@ createSlice({
selectors?: Selectors
}

const reducerDefinitionType: unique symbol = Symbol.for('rtk-reducer-type')
enum ReducerType {
export enum ReducerType {
reducer = 'reducer',
reducerWithPrepare = 'reducerWithPrepare',
asyncThunk = 'asyncThunk',
}

interface ReducerDefinition<T extends ReducerType = ReducerType> {
[reducerDefinitionType]: T
_reducerDefinitionType: T
}

export interface CaseReducerDefinition<
Expand Down Expand Up @@ -375,7 +374,7 @@ export interface ReducerCreators<State> {
ReturnType<_ActionCreatorWithPreparedPayload<Prepare>>
>
): {
[reducerDefinitionType]: ReducerType.reducerWithPrepare
_reducerDefinitionType: ReducerType.reducerWithPrepare
prepare: Prepare
reducer: CaseReducer<
State,
Expand Down Expand Up @@ -748,7 +747,7 @@ function buildReducerCreators<State>(): ReducerCreators<State> {
config: AsyncThunkSliceReducerConfig<State, any>
): AsyncThunkSliceReducerDefinition<State, any> {
return {
[reducerDefinitionType]: ReducerType.asyncThunk,
_reducerDefinitionType: ReducerType.asyncThunk,
payloadCreator,
...config,
}
Expand All @@ -765,13 +764,13 @@ function buildReducerCreators<State>(): ReducerCreators<State> {
},
}[caseReducer.name],
{
[reducerDefinitionType]: ReducerType.reducer,
_reducerDefinitionType: ReducerType.reducer,
} as const
)
},
preparedReducer(prepare, reducer) {
return {
[reducerDefinitionType]: ReducerType.reducerWithPrepare,
_reducerDefinitionType: ReducerType.reducerWithPrepare,
prepare,
reducer,
}
Expand Down Expand Up @@ -813,14 +812,14 @@ function handleNormalReducerDefinition<State>(
function isAsyncThunkSliceReducerDefinition<State>(
reducerDefinition: any
): reducerDefinition is AsyncThunkSliceReducerDefinition<State, any, any, any> {
return reducerDefinition[reducerDefinitionType] === ReducerType.asyncThunk
return reducerDefinition._reducerDefinitionType === ReducerType.asyncThunk
}

function isCaseReducerWithPrepareDefinition<State>(
reducerDefinition: any
): reducerDefinition is CaseReducerWithPrepareDefinition<State, any> {
return (
reducerDefinition[reducerDefinitionType] === ReducerType.reducerWithPrepare
reducerDefinition._reducerDefinitionType === ReducerType.reducerWithPrepare
)
}

Expand Down
2 changes: 2 additions & 0 deletions packages/toolkit/src/index.ts
View file
Open in desktop
Expand Up @@ -67,6 +67,7 @@ export type {
export {
// js
createSlice,
ReducerType,
} from './createSlice'

export type {
Expand All @@ -78,6 +79,7 @@ export type {
ValidateSliceCaseReducers,
CaseReducerWithPrepare,
ReducerCreators,
SliceSelectors,
} from './createSlice'
export type { ActionCreatorInvariantMiddlewareOptions } from './actionCreatorInvariantMiddleware'
export { createActionCreatorInvariantMiddleware } from './actionCreatorInvariantMiddleware'
Expand Down