Migrate to React 19 #4409
Draft
Migrate to React 19 #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We set the `@types/react` and `@types/react-dom` package resolutions to `npm:types-react` and `npm:types-react-dom` according to the React 19 migration guide.
- According to latest documentation of `@testing-library/react`, `fireEvent` methods are already wrapped inside `act` calls making manual wrapping unnecessary.
- There currently seems to be an issue involving `sinon` fake timers used by `vitest`, `@testing-library/react` only supporting `jest` fake timers and `@testing-library/user-event` using `setTimeout` internally to simulate user actions such as button presses. Currently `@testing-library/react` only works with `jest` fake timers, which means if there are any component updates while `sinon` fake timers are running in `vitest` , `@testing-library/react` will not catch it and things start to break.
- To workaround this issue, We have to setup the `user` by calling `userEvent.setup({ delay: null })`. The reason why We do this is because `@testing-library/user-event` uses `setTimeout` internally which cannot be awaited in a test while fake timers are running as it can cause the tests to indefinitely hang. So the current workaround is to disable the `delay` functionality of `userEvent` and prevent it from calling `setTimeout`. We also have to pass in `shouldAdvanceTime: true` to `vi.useFakeTimers()` as it can get around the issue of `@testing-library/react` not tracking `sinon` fake timers in `vitest`.
- Fixed test names in `fork.test.ts` which could cause the terminal to flicker in Windows.
- Added latest version of `@testing-library/dom` to `devDependencies` as it is required by `@testing-library/react`.
- `.mockReset()` should not be called in spies since it calls `.mockClear()` and returns the implementation to its **initial** form. In this case it was silencing some of the `act` related warnings emitted by `@testing-library/react` which needed to be resolved since they were calling issues. So `.mockReset()` calls on spies need to be changed to `.mockRestore()` calls since `.mockRestore()` restores the implementation to its **original** form.
aryaemami59
force-pushed
the
migrate-to-react-19
branch
from
ec60b9a
to
c1c42eb
Compare
…iddleware.test.ts`
…o migrate-to-react-19
…o migrate-to-react-19
…o migrate-to-react-19
…o migrate-to-react-19
…o migrate-to-react-19
…o migrate-to-react-19
aryaemami59
force-pushed
the
migrate-to-react-19
branch
from
60fa41a
to
48084da
Compare
…o migrate-to-react-19
…o migrate-to-react-19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
reactandreact-domto v19 beta.@types/reactand@types/react-dompackage resolutions tonpm:types-reactandnpm:types-react-domaccording to the React 19 migration guide.@testing-library/reactto latest version.@testing-library/user-eventto latest version.@testing-library/dom.ReactDOM.rendercalls with therenderfunction from@testing-library/reactas recommended in the React 19 migration guide.ReactDOM.unmountComponentAtNodecalls with thecleanupfunction from@testing-library/reactas recommended in the React 19 migration guide.actwrappers aroundfireEventmethod calls since they are already wrapped inactcalls.reactinpeerDependenciesto include version 19.consolespies.actwarnings emitted by@testing-library/react.sinonfake timers.