Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common utils from both adapter files #952

Merged
merged 3 commits into from
Mar 28, 2021

Conversation

markerikson
Copy link
Collaborator

This PR:

  • Dedupes some of the logic in the unsorted_state_adapter / sorted_state_adapter files by extracting some common utils
  • Fixes a leftover stray bit of commented out code in the serializability middleware

@netlify
Copy link

netlify bot commented Mar 28, 2021

Deploy preview for redux-starter-kit-docs ready!

Built with commit 6dc618d

https://deploy-preview-952--redux-starter-kit-docs.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 28, 2021

Size Change: -99 B (0%)

Total Size: 69.7 kB

Filename Size Change
dist/redux-toolkit.cjs.development.js 13.8 kB -39 B (0%)
dist/redux-toolkit.cjs.production.min.js 5.31 kB +12 B (0%)
dist/redux-toolkit.esm.js 13.7 kB -43 B (0%)
dist/redux-toolkit.umd.js 25.7 kB -38 B (0%)
dist/redux-toolkit.umd.min.js 11 kB +9 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/index.js 149 B 0 B

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 28, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6dc618d:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration

@markerikson markerikson force-pushed the feature/entity-adapter-cleanup branch from 64c1a12 to 6dc618d Compare March 28, 2021 17:55
@markerikson
Copy link
Collaborator Author

Amusing to note that switching for..of loops to for(let i = 0 loops does drop the size a bit (-94b min+gz). Will skip merging that, though - it'll be taken care of by creating a "modern JS" build.

@markerikson markerikson merged commit 61ec24c into master Mar 28, 2021
@markerikson markerikson deleted the feature/entity-adapter-cleanup branch March 28, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant