chore(build): improved build tools #981
Conversation
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 8358c0c https://deploy-preview-981--redux-starter-kit-docs.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8358c0c:
|
markerikson
changed the title
| target: 'es2017', | ||
| format: 'cjs', | ||
| }) | ||
| mod._compile(code, filename) |
There was a problem hiding this comment.
💬 hah, is this basically a homegrown ts-node using ESBuild? Nice :)
There was a problem hiding this comment.
yes, but much faster than ts-node
There was a problem hiding this comment.
There will be some complex logic, and I'm not comfortable with JS so I convert build file to TS
|
@markerikson I think umd production sourcemap problem should be fixed now |
hardfist
force-pushed
the
build-tools
branch
2 times, most recently
from
d25c83a
to
f20b18c
Compare
|
CI is green now, I may leave watch to another PR(I don't know whether you need the watch functionality since you already have tsdx watch) |
|
Spent the evening playing around with the existing
However, I don't have any of the changes that you put in here. I'm going to repoint this to |
|
Hey @hardfist . Now that I've merged this and am trying it out, I'm very confused by what's going on with the sourcemap stuff. Is some of this experimental / debug? What's it supposed to be doing? |
somthing wrong with sourcemap？ |
|
I'm just trying to understand what these lines are doing: it seems like it's debug code or something - why are we running asserts in the middle of a build script? |
It's kind of test to make sure the we can use the generated sourcemap to recover location from bundle to origin sourcefile, maybe it should be put into an separate test file. |
|
If it's not related to actual functionality, yeah. FYI, I've got |
I try to resolve the following problems of build tools