Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App.js location in todos example #1466

Closed
xuefengwang opened this issue Mar 2, 2016 · 3 comments
Closed

App.js location in todos example #1466

xuefengwang opened this issue Mar 2, 2016 · 3 comments

Comments

@xuefengwang
Copy link

In todos example, App.js is in the components folder. This seems a little confusing to me. In other examples, App.js is in the containers folder which makes more sense.

Thanks,
William

@xuefengwang
Copy link
Author

Created pull request; #1467

@gaearon
Copy link
Contributor

gaearon commented Mar 2, 2016

It is there for a reason. In some examples, App is connect()ed to Redux store and acts as a container. In other examples, it’s a purely presentational component that isn’t aware of Redux store.

I would like to convert more examples to make App presentational. For example, see #1354.

@xuefengwang
Copy link
Author

Ah, thanks for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants