Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings for store.observable #1723

Closed
babeal opened this issue May 13, 2016 · 4 comments · Fixed by #3067
Closed

typings for store.observable #1723

babeal opened this issue May 13, 2016 · 4 comments · Fixed by #3067
Labels
help wanted

Comments

@babeal
Copy link

babeal commented May 13, 2016

I might have missed something, but it seems that the new observable method on the store is not exposed in the typings. Is this intentional?
@gaearon
Copy link
Contributor

gaearon commented May 13, 2016

Not really intentional, these were just separate efforts. Please feel free to contribute!

@babeal
Copy link
Author

babeal commented May 13, 2016

Sounds easy enough. I can take this one on.

@Igorbek
Copy link
Contributor

Igorbek commented Jun 15, 2016

Note, that Store exposes observable as a symbol which cannot be expressed currently in the typings.

@timdorr
Copy link
Member

timdorr commented Sep 19, 2016

Sounds like we have to wait on TS to catch up here. If you can make it work anyways, feel free to submit a PR!

@timdorr timdorr closed this as completed Sep 19, 2016
@pinyin pinyin mentioned this issue Jul 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add types for current Observable interpolation interface pinyin/redux-1
4 participants
@timdorr @gaearon @Igorbek @babeal