Add types for current Observable interpolation interface #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, it's a good time. If anyone else wants to chime in with feedback, feel free. But I think this looks good as-is. |
|
Deploy preview for redux-docs ready! Built with commit 490c31e |
|
Sorry this took so long, but I think it's OK. Thanks! |
kiku-jw
pushed a commit
to kiku-jw/redux
that referenced
this pull request
Apr 6, 2019
* Add types about Observable interpolation * Run through Prettier * Also run through Prettier
This was referenced Sep 23, 2019
This was referenced Mar 11, 2020
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1723
According to #1725, the issue was closed because TypeScript wasn't supporting symbol-named properties at that time, which in my understanding is no longer the case.
Is it the time to add the types now?