Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter example HMR only works for React components but not for reducers #1804

Closed
philj0st opened this issue Jun 13, 2016 · 2 comments
Closed
Labels

Comments

@philj0st
Copy link

What is the current behavior?

The hot module reloading in the counter example only works for changes inside the react components but not for changes in the reducer. ex. if I change the INCREMENT action from return state + 1 to return state + 5 I get the following error:

[HMR] The following modules couldn't be hot updated: (Full reload needed)
This is usually because the modules which have changed (and their parents) do not know how to hot reload themselves. See http://webpack.github.io/docs/hot-module-replacement-with-webpack.html for more details.
process-update.js?e13e:89 [HMR]  - ./reducers/index.js

What is the expected behavior?
Wouldn't it be nice to have changes in react components and reducers work with persistent state.
Or would you say that's too confusing for a simple counter example .. but then again why is React HMR in there then?

@gaearon
Copy link
Contributor

gaearon commented Jun 13, 2016

Will probably fix this as part of #1800.

@timdorr
Copy link
Member

timdorr commented Jul 31, 2016

Closing in favor of #1800. You can pick up discussion there :)

@timdorr timdorr closed this as completed Jul 31, 2016
brandoncroberts pushed a commit to brandoncroberts/redux that referenced this issue Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants