Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribing to changes from the store doesn't always play nice with hot-reloading #301

Closed
mvestergaard opened this issue Jul 22, 2015 · 3 comments
Closed

Subscribing to changes from the store doesn't always play nice with hot-reloading #301

mvestergaard opened this issue Jul 22, 2015 · 3 comments
Labels
discussion question

Comments

@mvestergaard
Copy link

When using something like Rx observables to subscribe to changes in the store, it appears that hot-reloading can sometimes cause the subscriptions to be hooked up again, which can cause duplicate events.
@gaearon gaearon added this to the 1.0 milestone Jul 22, 2015
@gaearon
Copy link
Contributor

gaearon commented Jul 22, 2015

Yeah good point. Need to figure this out before shipping 1.0.

This was referenced Jul 27, 2015
Closed
Closed
@gaearon
Copy link
Contributor

gaearon commented Jul 31, 2015

Meh, this won't fit into 1.0.
Let's consolidate this with similar issues in #350.

@gaearon gaearon closed this as completed Jul 31, 2015
@gaearon gaearon mentioned this issue Aug 16, 2015
Closed
@gaearon gaearon mentioned this issue Aug 31, 2015
Merged
@gaearon
Copy link
Contributor

gaearon commented Aug 31, 2015

Now we encourage people to use hot module replacement API directly, so that you have full control: #667

@gaearon gaearon mentioned this issue Aug 31, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @mvestergaard