Refactor combineReduer's Unexpected State Shape Warning #1118
Conversation
jridgewell
force-pushed
the
combineReducers-unexpected-shape
branch
from
b88deec
to
5bce135
Compare
|
This looks good to me. 👍 for using |
|
Someone else should review this too, though, since I'm not as familiar with this module. |
| @@ -15,8 +15,8 @@ function getUndefinedStateErrorMessage(key, action) { | |||
| ) | |||
| } | |||
|
|
|||
| function getUnexpectedStateKeyWarningMessage(inputState, outputState, action) { | |||
| var reducerKeys = Object.keys(outputState) | |||
| function getUnexpectedStateShapeWarningMessage(inputState, reducer, action) { | |||
There was a problem hiding this comment.
The argument should probably be called reducers, not reducer.
|
I think @ellbee should remember this better than me. |
|
I have just been playing with this, and I am pretty sure that this behaves the same as what is currently there. |
|
Leaving this for you to review then 👍 |
The shape of the previous state is irrelevant, what we’re actually testing is that state has the same shape as our reducer object `finalReducers`. Also fixes the algorithm to be O(n) by using `#hasOwnProperty` vs doing an array search.
jridgewell
force-pushed
the
combineReducers-unexpected-shape
branch
from
5bce135
to
e5aabde
Compare
|
So, the changes in this PR are passing the finalReducer instead of outputState, the switch to |
…hape Refactor combineReduer's Unexpected State Shape Warning
|
Out in 3.0.6, thanks! |
The shape of the previous state is irrelevant, what we’re actually
testing is that state has the same shape as our reducer object
finalReducers.Also fixes the algorithm to be O(n) by using
#hasOwnPropertyvs doingan array search O(n2).