Give the initial action a special type #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,8 +1,12 @@ | |||
| import composeMiddleware from './utils/composeMiddleware'; | |||
|
|
|||
| const INIT_ACTION = { | |||
| type: '@@INIT' | |||
There was a problem hiding this comment.
Camelcase would be sexier (example on MDN)
There was a problem hiding this comment.
I was actually kinda torn on this one. :-)
Action types are all caps by convention.
I'd rather keep @@ as the marker of “special stuff” and keep using all caps for action types and camel for state keys:
export const StateKeys = {
LOG: '@@log'
};
export const ActionTypes = {
JUMP_TO_STATE: '@@JUMP_TO_STATE'
};
gaearon
added a commit
that referenced
this pull request
Jun 17, 2015
Give the initial action a special type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #114.
I want to establish a convention for “built-in” and “devtools” action types (more will come in #113) so that the tools are able to distinguish them, and so the user doesn't feel compelled to handle them and can clearly see that they are not from their app.
Thanks to @ooflorent for the
@@naming tip.