Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reducer generics more generic #2515

Closed
wants to merge 1 commit into from
Closed

Conversation

sbuzonas
Copy link

This enforces that the action parameter extends Action for strongly typed implementations, and defaults to AnyAction for the case where an action may not be explicitly typed.

Enhancement to #2467
Addresses an issue discovered in a failed build for DefinitelyTyped/DefinitelyTyped#17777

@sbuzonas sbuzonas closed this Jul 15, 2017
@sbuzonas
Copy link
Author

This doesn't work because of the typescript version. It would need 2.3.

Should it be against next instead? The current latest version breaks a lot of types that extend Action rather than AnyAction

@sbuzonas sbuzonas reopened this Jul 15, 2017
@sbuzonas
Copy link
Author

Closing because I have no idea how to correctly fix this. Opened #2516 for discussion.

@sbuzonas sbuzonas closed this Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant