Update WritingTests.md #2654
Merged
Update WritingTests.md #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example for middleware testing needs to destructure the `store` param that is being passed in to `invoke()`. Currently, the example shows `invoke((dispatch, getState) => { ... })` on LINE 456, but it should read as `invoke(({ dispatch, getState }) => { ... })`.
|
Thanks! |
|
@timdorr Actually... I was wrong. I was using the middleware+thunk example to write a test for custom middleware and I was handling the inner logic differently. The example on the website is already correct. Can I take this back, haha? 😅 |
|
No worries. That tripped me up too! I'll revert. |
timdorr
added a commit
that referenced
this pull request
Oct 11, 2017
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
Example for middleware testing needs to destructure the `store` param that is being passed in to `invoke()`. Currently, the example shows `invoke((dispatch, getState) => { ... })` on LINE 456, but it should read as `invoke(({ dispatch, getState }) => { ... })`.
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
This reverts commit 953983b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example for middleware testing should destructure the
storeparam that is being passed throughinvoke(). Currently, the example showsinvoke((dispatch, getState) => { ... })on LINE 456, but it should read asinvoke(({ dispatch, getState }) => { ... }).