Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Writing Tests recipe with hooks #3876

Merged
merged 1 commit into from
May 29, 2021

Conversation

nickmccurdy
Copy link
Contributor

@nickmccurdy nickmccurdy commented Sep 1, 2020


name: "\U0001F4D6 New/Updated Documentation Content"
about: Adding a new docs page, or updating content in an existing docs page

PR Type

Does this PR add a new page, or update an existing page?
Existing

Checklist

What docs page is being added or updated?

  • Section: Components and Connected Components
  • Page: Writing Tests

For Updating Existing Content

What updates should be made to the page?

The Components and Connected Components sections are merged together, using React Redux hooks as an example of connected components (since they're not usually separate from unconnected components any more). This makes them more consistent with the Testing Library recipe (which I'd like to remove in favor of this one) and easier to understand for new hook-based components.

Do these updates change any of the assumptions or target audience? If so, how do they change?

They assume they're using React 16.8+ with hooks, which should be a fair assumption as the new tutorial already uses it.

@nickmccurdy nickmccurdy marked this pull request as draft September 1, 2020 01:04
@netlify
Copy link

netlify bot commented Sep 1, 2020

Deploy preview for redux-docs ready!

Built with commit 841fe44

https://deploy-preview-3876--redux-docs.netlify.app

@nickmccurdy nickmccurdy marked this pull request as ready for review September 1, 2020 01:43
@markerikson markerikson merged commit 28489af into reduxjs:master May 29, 2021
@nickmccurdy nickmccurdy deleted the writing-tests-hooks branch July 8, 2021 20:58
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Simplify Writing Tests recipe with hooks

Former-commit-id: e8c13c9
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Simplify Writing Tests recipe with hooks

Former-commit-id: e8c13c9
Former-commit-id: 810c91c
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Simplify Writing Tests recipe with hooks

Former-commit-id: e8c13c9
Former-commit-id: 810c91c
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Simplify Writing Tests recipe with hooks

Former-commit-id: e8c13c9
Former-commit-id: 810c91c
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Simplify Writing Tests recipe with hooks

Former-commit-id: e8c13c9
Former-commit-id: 810c91c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants