fix: miniKindOf returns 'object' for plain object #4160
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit aa48de7:
|
|
✔️ Deploy Preview for redux-docs ready! 🔨 Explore the source changes: aa48de7 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/6140b57f59ac13000830edf4 😎 Browse the preview: https://deploy-preview-4160--redux-docs.netlify.app |
|
OK, you and #4173 have the exact same PR. I'm going to merge this one since it's first. Thanks! |
|
Note that we need this fix applied to the |
|
thanks ! |
|
@timdorr Did this actually make make it into our 4.x branch? I don't think it did. |
|
I thought there was a PR for that branch? I guess it didn't. |
name: "miniKindOf returns 'object' for plain object"
about: miniKindOf returns 'object' for plain object
PR Type
Does this PR add a new feature, or fix a bug?
Fix a bug.
Why should this PR be included?
Reference link：https://github.com/jonschlinkert/kind-of/blob/abab085d65f7ee978011da8f135291892fcd97db/index.js#L54
When I read the redux source code, its incorrect behavior confused me.
Checklist
Have you added an explanation of what your changes do and why you'd like us to include them?
Is there an existing issue for this PR?
Have the files been linted and formatted?
Have the docs been updated to match the changes in the PR?
Have the tests been updated to match the changes in the PR?
Have you run the tests locally to confirm they pass?
Bug Fixes
What is the current behavior, and the steps to reproduce the issue?
For a plain object,miniKindOf should returns ""
What is the expected behavior?
For a plain object,miniKindOf should returns "object" instead of ""
How does this PR fix the problem?
use
Object.prototype.toString.call()to get the correct type of plain object instead oftypeof