fixed unsubscribe bug for issue #938 #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,6 +62,7 @@ export default function createStore(reducer, initialState) { | |||
|
|
|||
| return function unsubscribe() { | |||
| var index = listeners.indexOf(listener); | |||
| if (index === -1)return; | |||
There was a problem hiding this comment.
Please be consistent with the project style.
In this case I'd rather write it as
if (index !== -1) {
listeners.splice(index, 1);
}
There was a problem hiding this comment.
Nitpick: index > -1 - saved 2 chars!
There was a problem hiding this comment.
I don't mind either way. 😛
I was kind of a fan of > -1 for some time, but now I think !== -1 makes the intention clearer.
But whatever, I'm fine with either.
|
Thank you for the PR! I left a nit, will be happy to merge after it's fixed. |
gaearon
added a commit
that referenced
this pull request
Oct 23, 2015
fixed unsubscribe bug for issue #938
|
I changed your fix to cover one more edge case: b7031ce |
|
nice 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.