Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #95

Closed
wants to merge 1 commit into from
Closed

Conversation

DenisIzmaylov
Copy link
Contributor

No description provided.

@gaearon
Copy link
Contributor

gaearon commented Jun 15, 2015

I don't mind omitting parens when there is a single argument.

Do you folks think it reads better?

@emmenko
Copy link
Contributor

emmenko commented Jun 15, 2015

I would also prefer no brackets for only one argument

@DenisIzmaylov
Copy link
Contributor Author

Yes, I think it's more readable for almost people.
But we can vote in the community.
I fixed it according https://github.com/airbnb/javascript#arrow-functions which is basically using is default code style. Or do you prefer other?

@gaearon
Copy link
Contributor

gaearon commented Jun 15, 2015

Let's go with Airbnb's style guide. But if we do that, I'd like to see eslint configuration to enforce as much of it as possible, and also update the source code.

@gaearon
Copy link
Contributor

gaearon commented Jun 15, 2015

Closing in favor of #97.

@gaearon gaearon closed this Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants