Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As of TypeScript 3.1.1, types erroneously fall back to arity-agnostic createSelector signature when used with arrays #420

Closed
nickmccurdy opened this issue Aug 10, 2019 · 0 comments · Fixed by #486
Closed

As of TypeScript 3.1.1, types erroneously fall back to arity-agnostic createSelector signature when used with arrays #420

nickmccurdy opened this issue Aug 10, 2019 · 0 comments · Fixed by #486
Labels
TypeScript
Milestone
4.1

Comments

@nickmccurdy
Copy link
Contributor

nickmccurdy commented Aug 10, 2019 •
edited

As far as I'm aware, this breaks any usage of Reselect's array signature with TypeScript 3.1.1+. I'm not sure what causes this yet, but I'm hoping that #366 will also fix this by using a mapped generic rest tuple. Older TypeScript versions work fine, but now that 3.1.1 is already 10 months old it seems like this may be a common issue.

Discussion: https://twitter.com/jessidhia/status/1159660672000487424
Reproduction with failing type tests: https://travis-ci.com/nickmccurdy/reselect/jobs/224127648#L1087-L1115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TypeScript
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

TypeScript update for 4.x eXamadeus/reselect
2 participants
@nickmccurdy @markerikson