Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TypeScript for v5.0.0 #484

Closed
eXamadeus opened this issue Feb 8, 2021 · 2 comments
Closed

Improve TypeScript for v5.0.0 #484

eXamadeus opened this issue Feb 8, 2021 · 2 comments
Milestone

Comments

@eXamadeus
Copy link
Contributor

See #480 for more context and initial PR

Upgrade Types to Support TypeScript 4.1+ Capabilities

In version v5.0.0, reselect can take advantage of some of the interesting new features of TypeScript. Using 4.1+ we can accomplish these goals:

Goals


Some caveats

eXamadeus added a commit to eXamadeus/reselect that referenced this issue Feb 8, 2021
@eXamadeus eXamadeus mentioned this issue Feb 8, 2021
3 tasks
@eXamadeus eXamadeus changed the title TypeScript updates for v5.0.0 Improve TypeScript for v5.0.0 Feb 8, 2021
@markerikson markerikson added this to the 5.0 milestone Oct 17, 2021
@markerikson
Copy link
Contributor

Based on the changes I've made in #486 and locally, I actually see most of this as being doable in a 4.x release, and in fact I've pulled them in already. It does require bumping our TS minimum to 4.2+, but frankly I consider changing TS version targets to not require a major release.

@eXamadeus
Copy link
Contributor Author

eXamadeus commented Nov 2, 2021

This has been completed! Released in 4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants