Typed the props argument on the selectors created by createSelector, and added typings test cases.
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests should probably be runnable by Travis CI. Anyone know how to fix? |
Current coverage is 100%
|
| @@ -5,22 +5,22 @@ | |||
|
|
|||
| declare module Reselect { | |||
|
|
|||
| type Selector<TInput, TOutput> = (state: TInput, props?: any) => TOutput; | |||
| type Selector<TInput, TProps, TOutput> = (state: TInput, TProps, props?: TProps) => TOutput; | |||
There was a problem hiding this comment.
Was this a typo? That looks like you accidentally included a required implicit any parameter named TProps.
| @@ -0,0 +1,22 @@ | |||
|
|
|||
| export type RootState = { | |||
| items: {[key: string]: { | |||
There was a problem hiding this comment.
Can you convert tabs to spaces to match the other files? It's a small thing, but it'll help avoid whitespace changes on future diffs.
There was a problem hiding this comment.
|
🎉 Thanks for this @geon! And thanks @threehams for reviewing and merging. Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is done by simply running
tscin the/tests/typings/folder. If it compiles, everything is fine.