Fix parameter expansion and improve OutputSelector readability #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us better-looking intersectioned objects, but avoids the errors I saw with recursively-expanded types.
The `Result` type always comes from the `Combiner` anyway, so removing that generic arg lets us avoid a bunch of extra types showing up in hover previews.
markerikson
force-pushed
the
feature/413-ts-checks
branch
from
621ed1f
to
fb6bccd
Compare
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 105 105
Branches 24 24
=========================================
Hits 105 105
|
markerikson
force-pushed
the
feature/413-ts-checks
branch
from
d211574
to
d91ddf5
Compare
markerikson
force-pushed
the
feature/413-ts-checks
branch
from
d91ddf5
to
75b6e01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
MergeParametersto only do a single level of type expansion rather than recursive. This fixes [RTKQ] Type conflicts with TypedUseSelectorHook when using reselect 4.1.3 redux-toolkit#1750 , where RTKQ types broke any selector definitions, but retains some improvement of intersected parameters (intersected objects will look like{a, b, c}rather than{a} & {b} & {c})OutputSelectorFieldstype to infer theResulttype asReturnType<Combiner>, and removes theResultgeneric. This simplifies the preview type content for a selector considerably.MergeParametersto replace empty object parameters withnever, under the assumption that this is the result of two objects with incompatible fields being intersected (such as{a: number} & {a: string}). This will force compile errors if you attempt to use them. Deeper nested incompat should be caught by TS directly.// @ts-ignorehack I'd thrown into the middle ofcreateStructuredSelector, because that doesn't work when you compile the types. Still not sure why a tuple can't be spread there, but laundering it asstate: Head<SelectorParams>, ...params: Tail<SelectorParams>is a legit fix now.