This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Put binaryTargets in ENV var #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterp
reviewed
Mar 17, 2020
peterp
approved these changes
Mar 17, 2020
|
AWESOME Do you plan to cut a new CRA release with this in there? Sounds like it'll be a big improvement in Windows users' lives. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterp I noticed a couple of people saying they had to change binaryTargets to
["native", "windows"]but I wonder if that's really necessary or if just"native"would work on its own. This PR assumes that just"native"is okay, can you test on your Window VM?I'm going to update the tutorial once this goes into a real release to let users know they need to set the environment variable on Netlify to
"rhel-openssl-1.0.x".