Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Remove tsconfig file, restore prisma default autocompletion! #60

Merged
merged 1 commit into from
May 29, 2020

Conversation

guledali
Copy link
Contributor

@guledali guledali commented May 29, 2020

@guledali
Copy link
Contributor Author

guledali commented May 29, 2020

@peterp @thedavidprice

Could you guys look into this pull-request!

@thedavidprice thedavidprice requested a review from peterp May 29, 2020 20:21
@thedavidprice
Copy link
Contributor

thedavidprice commented May 29, 2020

Thanks for this @guledali I want to make sure Peter gets the final say on merging this -- I've added him as Reviewer.

Question: can you confirm this does solve the Prisma Autocomplete bug for you? Also, have you played around locally with the API to confirm there are no unexpected effects? It's my understanding this was added proactively -- but I want us to be sure there wasn't something with generators or config that could be done now and requires tsconfig. (thinking out loud...) edit: just read original Issue -- nothing to see here, folks!

@peterp peterp merged commit c73d819 into redwoodjs:master May 29, 2020
@peterp
Copy link
Collaborator

peterp commented May 29, 2020

Thanks @guledali

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug) Fix prisma not autocompleting in services files
3 participants