Fix Maximum Call Stack Size Exceeded when using requireAuth with Func… (

#5134)

packages/graphql-server/src/functions/__tests__/globalContext.test.ts

@@ -0,0 +1,39 @@
+import {
+  context as globalContext,
+  getAsyncStoreInstance,
+  setContext,
+} from '../../globalContext'
+
+describe('Global context with context isolation', () => {
+  beforeAll(() => {
+    process.env.DISABLE_CONTEXT_ISOLATION = '0'
+  })
+
+  it('Should work when assigning directly into context', async () => {
+    const asyncStore = getAsyncStoreInstance()
+
+    asyncStore.run(new Map(), () => {
+      // This is the actual test
+      globalContext.myNewValue = 'bazinga'
+
+      expect(globalContext.myNewValue).toBe('bazinga')
+    })
+
+    // Check that context was isolated
+    expect(globalContext.myNewValue).not.toBe('bazinga')
+  })
+
+  it('Should work when using setContext', async () => {
+    const asyncStore = getAsyncStoreInstance()
+
+    asyncStore.run(new Map(), () => {
+      // This is the actual test
+      setContext({ anotherValue: 'kittens' })
+
+      expect(globalContext.anotherValue).toBe('kittens')
+    })
+
+    // Check that context was isolated
+    expect(globalContext.anotherValue).not.toBe('kittens')
+  })
+})

packages/graphql-server/src/functions/useRequireAuth.ts

@@ -4,7 +4,6 @@ import { getAuthenticationContext } from '@redwoodjs/api'
 
 import {
   getAsyncStoreInstance,
-  setContext,
   context as globalContext,
 } from '../globalContext'
 
@@ -39,7 +38,6 @@ export const useRequireAuth = ({ handlerFn, getCurrentUser }: Args) => {
             : null
 
           globalContext.currentUser = currentUser
-          setContext(globalContext)
         }
       } catch (e) {
         return {

packages/graphql-server/src/globalContext.ts

@@ -40,6 +40,13 @@ export const createContextProxy = () => {
         const ctx = store?.get('context') || {}
         return ctx[property]
       },
+      set: (_target, property: string, newVal) => {
+        const store = getAsyncStoreInstance().getStore()
+        const ctx = store?.get('context') || {}
+        ctx[property] = newVal
+        store?.set('context', ctx)
+        return true
+      },
     })
   } else {
     return GLOBAL_CONTEXT