Skip to content

Commit

Permalink
Fix router lint issue | Bump and pin @types/react to 17.0.3 (#2058)
Browse files Browse the repository at this point in the history
* Fix router lint issue | Bump and pin @types/react to 17.0.3

* Remove generic from Params React.FC

Co-authored-by: David Price <thedavid@thedavidprice.com>
  • Loading branch information
dac09 and thedavidprice committed Mar 23, 2021
1 parent 7f21240 commit b96a37a
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 10 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -48,7 +48,7 @@
"whatwg-fetch": "3.4.1"
},
"resolutions": {
"@types/react": "17.0.2",
"@types/react": "17.0.3",
"prop-types": "15.7.2",
"react-dom": "17.0.1",
"react": "17.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/auth/package.json
Expand Up @@ -11,7 +11,7 @@
"@auth0/auth0-spa-js": "^1.7.0",
"@supabase/supabase-js": "^1.3.3",
"@types/netlify-identity-widget": "^1.4.1",
"@types/react": "^17.0.2",
"@types/react": "17.0.3",
"firebase": "^7.14.5",
"firebase-admin": "^9.1.1",
"gotrue-js": "^0.9.29",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Expand Up @@ -33,7 +33,7 @@
"@testing-library/jest-dom": "5.11.6",
"@types/jest": "^26.0.10",
"@types/node": "^14.6.0",
"@types/react": "^17.0.2",
"@types/react": "17.0.3",
"@types/react-dom": "^17.0.1",
"@types/webpack": "^4.41.11",
"babel-jest": "^26.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/router/src/params.tsx
Expand Up @@ -9,7 +9,7 @@ export interface ParamsContextProps {

export const ParamsContext = createNamedContext<ParamsContextProps>('Params')

export const ParamsProvider: React.FC<{}> = ({ children }) => {
export const ParamsProvider: React.FC = ({ children }) => {
const [params, setParams] = useState<Record<string, string> | undefined>(
undefined
)
Expand Down
2 changes: 1 addition & 1 deletion packages/testing/package.json
Expand Up @@ -14,7 +14,7 @@
"@redwoodjs/router": "^0.27.1",
"@redwoodjs/web": "^0.27.1",
"@testing-library/react": "11.2.2",
"@types/react": "^17.0.2",
"@types/react": "17.0.3",
"msw": "^0.21.2"
},
"scripts": {
Expand Down
4 changes: 3 additions & 1 deletion packages/web/package.json
Expand Up @@ -13,7 +13,6 @@
"dependencies": {
"@apollo/client": "^3.3.11",
"@redwoodjs/auth": "^0.27.1",
"@types/react": "^17.0.2",
"core-js": "3.6.5",
"graphql": "^15.3.0",
"proptypes": "^1.1.0",
Expand All @@ -22,6 +21,9 @@
"peerDependencies": {
"react": "^17.0.1"
},
"devDependencies": {
"@types/react": "17.0.3"
},
"scripts": {
"build": "yarn build:js && yarn build:types",
"prepublishOnly": "yarn cross-env NODE_ENV=production yarn build",
Expand Down
14 changes: 10 additions & 4 deletions yarn.lock
Expand Up @@ -4090,12 +4090,13 @@
dependencies:
"@types/react" "*"

"@types/react@*", "@types/react@17.0.2", "@types/react@^17.0.2":
version "17.0.2"
resolved "https://registry.yarnpkg.com/@types/react/-/react-17.0.2.tgz#3de24c4efef902dd9795a49c75f760cbe4f7a5a8"
integrity sha512-Xt40xQsrkdvjn1EyWe1Bc0dJLcil/9x2vAuW7ya+PuQip4UYUaXyhzWmAbwRsdMgwOFHpfp7/FFZebDU6Y8VHA==
"@types/react@*", "@types/react@17.0.3":
version "17.0.3"
resolved "https://registry.yarnpkg.com/@types/react/-/react-17.0.3.tgz#ba6e215368501ac3826951eef2904574c262cc79"
integrity sha512-wYOUxIgs2HZZ0ACNiIayItyluADNbONl7kt8lkLjVK8IitMH5QMyAh75Fwhmo37r1m7L2JaFj03sIfxBVDvRAg==
dependencies:
"@types/prop-types" "*"
"@types/scheduler" "*"
csstype "^3.0.2"

"@types/reactcss@*":
Expand All @@ -4115,6 +4116,11 @@
resolved "https://registry.yarnpkg.com/@types/retry/-/retry-0.12.0.tgz#2b35eccfcee7d38cd72ad99232fbd58bffb3c84d"
integrity sha512-wWKOClTTiizcZhXnPY4wikVAwmdYHp8q6DmC+EJUzAMsycb7HB32Kh9RN4+0gExjmPmZSAQjgURXIGATPegAvA==

"@types/scheduler@*":
version "0.16.1"
resolved "https://registry.yarnpkg.com/@types/scheduler/-/scheduler-0.16.1.tgz#18845205e86ff0038517aab7a18a62a6b9f71275"
integrity sha512-EaCxbanVeyxDRTQBkdLb3Bvl/HK7PBK6UJjsSixB0iHKoWxE5uu2Q/DgtpOhPIojN0Zl1whvOd7PoHs2P0s5eA==

"@types/serve-static@*":
version "1.13.9"
resolved "https://registry.yarnpkg.com/@types/serve-static/-/serve-static-1.13.9.tgz#aacf28a85a05ee29a11fb7c3ead935ac56f33e4e"
Expand Down

0 comments on commit b96a37a

Please sign in to comment.