Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Add a way to define a custom Provider and configuration #1595

Closed
3 of 4 tasks
peterp opened this issue Dec 29, 2020 · 7 comments
Closed
3 of 4 tasks

Storybook: Add a way to define a custom Provider and configuration #1595

peterp opened this issue Dec 29, 2020 · 7 comments

Comments

@peterp
Copy link
Contributor

peterp commented Dec 29, 2020

We should allow the users to define a storybook.preview.js configuration file. This would allow people to add additional decorators.

  • Add storybookPreviewConfig path to getPaths(), it should be a web/config/storybook.preview.js file.
  • Import that over here:
  • Make sure that it's optional and that a user is able to define a new decorator.
  • Document this feature.
@viveksonar
Copy link

Hello is this issue still open.
New to open source and would love to contribute to this.

@peterp
Copy link
Contributor Author

peterp commented Jan 7, 2021

Hi @viveksonar, it is indeed!

I would love to have you contribute it, hit me up on discord if you need any help

@jangxyz
Copy link
Contributor

jangxyz commented Mar 10, 2021

Hi, any updates?

I've noticed that storybook has upgraded to v6, so I wonder whether redwood should support v6 out of the box. I left a topic in the forum.

@viveksonar
Copy link

viveksonar commented Mar 10, 2021 via email

@thedavidprice
Copy link
Contributor

I believe this is now resolved via #2054 which will be included in v0.28

@peterp correct?

@peterp
Copy link
Contributor Author

peterp commented Mar 23, 2021

Yup, this is resolved!

@peterp
Copy link
Contributor Author

peterp commented Mar 23, 2021

Resolved by #2054

@peterp peterp closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants