Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead link to auth command implementations in CLI readme.md #5810

Closed
Philzen opened this issue Jun 23, 2022 · 1 comment · Fixed by #5826
Closed

Dead link to auth command implementations in CLI readme.md #5810

Philzen opened this issue Jun 23, 2022 · 1 comment · Fixed by #5826
Assignees
@dac09

Comments

@Philzen
Copy link
Contributor

Philzen commented Jun 23, 2022

Currently evaluating the process on contributing a new auth provider, i wanted to take a look at what the CLI setup command does behind the scenes and how such a command would be implemented.

Fortunately, the README.md in the cli package provides some insights in the section Adding a Provider to the Auth Generator, however the link to the implementation leads to a 404.

It's this one: src/commands/generate/auth/providers
@Philzen Philzen mentioned this issue Jun 23, 2022
Open
Philzen added a commit to Philzen/redwood that referenced this issue Jun 25, 2022
@Philzen
Update link to auth/providers implementations
5f54a78 
Closes redwoodjs#5810
@Philzen Philzen mentioned this issue Jun 25, 2022
Merged
@Philzen
Copy link
Contributor Author

Philzen commented Jun 25, 2022

I believe i found it, wasn't so hard to find after all 😉 – see attached PR

dac09 added a commit that referenced this issue Jun 27, 2022
@Philzen @dac09
Update link to auth/providers implementations (#5826)
a8730d0 
* Update link to auth/providers implementations

Closes #5810

* Update required exports explanation and example code

The required export  `packages` has thankfully been split into `apiPackages` and `webPackages`. This change updates the documentation accordingly.

Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dac09 dac09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update link to auth/providers implementations Philzen/redwood
2 participants
@dac09 @Philzen