Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Storybook opens automatically though CLI doc implicitly suggests otherwise #6062

Open
1 task done
Philzen opened this issue Jul 27, 2022 · 4 comments
Open
1 task done

Comments

@Philzen
Copy link
Contributor

Philzen commented Jul 27, 2022

The CLI doc explicitly lists the --open command option and does not make any statement about this happening anyways – which tells me as a reader that it won't automatically try to open up any new browser windows on my system.

https://redwoodjs.com/docs/cli-commands#storybook

It should at least mention that --open is the default behavior anyway (so it's partially pointless to list it here) and also inform about the --no-open option.

  • I'm interested in working on this
@Philzen Philzen added the bug/needs-info More information is needed for reproduction label Jul 27, 2022
@Philzen
Copy link
Contributor Author

Philzen commented Jul 27, 2022

Actually this behavior is a real nuisance for our development team. While we have the ability to configure the Redwood dev server's behavior in redwood.toml via

[browser]
  open = false

there seems to be no way to configure Storybook to act alike, other than adding --no-open whenever we fire up yarn rw storybook.

It'd be awesome if that could be changed in v3 or if there would be any means of configuring that w/o having to supply the CLI option manually everytime.

@callingmedic911
Copy link
Member

Sorry for delay on getting back to you @Philzen! I just had an discussion with team and I think we should update the doc and mention what's the default behavior of command is for this case. We usually try to do that but missed it somehow for this one. Thanks for bring it up!

@Josh-Walker-GM
Copy link
Collaborator

@jtoar I think we can close this one given #6722 updated the docs to say that it was the default behaviour to open automatically and that --no-open is available to change the behaviour?

@pantheredeye
Copy link
Collaborator

@Tobbe bumped for Josh's comment above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

5 participants