Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking in main branch: Forms Breaking due to #886 (Move Forms to Separate Package) #901

Closed
thedavidprice opened this issue Jul 28, 2020 · 0 comments · Fixed by #903
Closed
Assignees
Labels
bug/confirmed We have confirmed this is a bug topic/forms

Comments

@thedavidprice
Copy link
Contributor

thedavidprice commented Jul 28, 2020

@peterp continuing from #886

It seems the code + comments intended this to be backward compatible. But I ran into errors upgrading to canary 0.14.1-canary.26 as well as running locally with rwt (I first noticed it after upgrading up Cypress Project to test Prisma 2.3.)

Here's what I'm seeing in my existing project after upgrading to canary. This is for an existing CRUD. I did try creating a new CRUD, which also didn't work (checked the PR and saw the import change wasn't applied to generators, so makes sense.)

Screen Shot 2020-07-27 at 10 35 22 PM

Deprecation notice is coming through just fine in Console.

For PostForm.js I updated:

import {
  Form,
  FormError,
  FieldError,
  Label,
  TextField,
  Submit,
} from '@redwoodjs/web'

to

import {
  Form,
  FormError,
  FieldError,
  Label,
  TextField,
  Submit,
} from '@redwoodjs/forms'

And everything worked fine. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug topic/forms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants