[Bug?]: fastify server not handling periods in query params

[ajluker]

What's not working?

It doesn't look like the fastify server is returning the index when a query parameter contains a period.

For example, appending this to any routed URL works:
/your-route?this_Should_be_ok

But this doesnt:
/your-route?this_Shoul.d_be_ok

Instead of being served the index html file, I receive a 404

How do we reproduce the bug?

Tack ?this_Shoul.d_be_ok onto any path

What's your environment? (If it applies)

Binaries:
    Node: 18.18.0 - /tmp/xfs-1fd38dbd/node
    Yarn: 3.2.3 - /tmp/xfs-1fd38dbd/yarn
  npmPackages:
    @redwoodjs/auth-custom-setup: 6.4.2 => 6.4.2 
    @redwoodjs/cli-storybook: 6.4.2 => 6.4.2 
    @redwoodjs/core: 6.4.2 => 6.4.2

Are you interested in working on this?

• I'm interested in working on this

[dthyresson]

Hi @ajluker and thanks for the issue write up.

Could you help me understand the issue more by sharing an example repo that reproduces this (so we can quickly run and see in in action)?

• Are you seeing this in dev or in prod? If in prod, when are you deployed?
• Are you seeing this via "yarn rw serve" ?

If a repo isn't available, could you provide some steps to recreate from scratch, for example:

• create rw app
• configure fastify as "such"
• yarn rw g page home /home
• yarn rw dev or yarn rw serve
• go to /home, ok
• go to /home?this-ok
• go to /home?this/not.ok and 404s

So we can be sure we are seeing the asme behavior you are

[dthyresson]

I was able to reproduce using those basic steps above (with no septic fastify config, just oui of of) with yarn rw serve.

However, url encoding the querystring params like http://localhost:8910/home?this_ok%2Enot was ok. If just a plain period, then a not found error occurs,

Need to determine if Fastify expect urls to be encoded or not -- or if there is a setting to configure.

[dthyresson]

@jtoar or @Josh-Walker-GM do you think that the not found handler is invoked because it thinks such a url with a period is an asset/extension (like a .png, .jpg etc)? And thus the not found?

See:

redwood/packages/api-server/src/plugins/withWebServer.ts

Line 60 in a231840

const requestedExtension = path.extname(req.url)

[dthyresson]

According to path docs:

The path.extname() method returns the extension of the path, from the last occurrence of the . (period) character to end of string in the last portion of the path. If there is no . in the last portion of the path, or if there are no . characters other than the first character of the basename of path (see path.basename()) , an empty string is returned.

See: https://nodejs.org/api/path.html#pathextnamepath

@ajluker Is there a specific reason you need have a period in the url that isn't URL encoded? Seems to think that when a period is in the url, it's an extension?

[dthyresson]

Also @jtoar seems this new behavior was introduced in

https://github.com/redwoodjs/redwood/pull/9272/files

[ajluker]

I can work around it by encoding for sure, but I shouldn't really have to, it's part of the spec to allow unencoded period characters in urlencoded search params:

https://url.spec.whatwg.org/#application-x-www-form-urlencoded-percent-encode-set

[dthyresson]

I can work around it by encoding for sure, but I shouldn't really have to, it's part of the spec to allow unencoded period characters in urlencoded search params:

https://url.spec.whatwg.org/#application-x-www-form-urlencoded-percent-encode-set

@ajluker Agreed.

I just found the PR that changed the behavior and assigned to @jtoar to explore. Please see: https://github.com/redwoodjs/redwood/pull/9272/files

It was put into to help with serving static assets, but had some downstream effect.

Thanks for reporting and now we have a way to reproduce and found the likely cause.

[ajluker]

Thanks for being responsive!

[jtoar]

Just adding to the reproduction steps here that this only works if the page isn't prerendered