7.0 RC: Remove hardcoded check for session.id
#10013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ny user data defined by `allowedUserFields` not only `id` Closes #10005
cannikin
added
bug/confirmed
jtoar
approved these changes
Feb 14, 2024
jtoar
pushed a commit
that referenced
this pull request
Feb 15, 2024
Fixes bug when User table had a primary key other than `id`. Shout out to @will-ks for finding this! ### Impact For apps which had a primary key other than `id`, all users will be logged out on their next request after this is deployed. Not sure if we consider that breaking? But it is 7.0 so anything goes! Closes #10005
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 16, 2024
* 'main' of github.com:redwoodjs/redwood: (22 commits) fix: Handle static assets on the `rw-serve-fe` (redwoodjs#10018) fix(server): fix env var loading in `createServer` (redwoodjs#10021) fix(deps): remove react types packages from `@redwoodjs/testing` dependencies (redwoodjs#10020) chore(release): add back `update-package-versions` task (redwoodjs#10017) chore(renovate): Disable for experimental apollo package (redwoodjs#10016) RSC: server cells lowercase data function (redwoodjs#10015) fix(RSC/SSR): pass CLI options through to apiServerHandler (redwoodjs#10012) 7.0 RC: Remove hardcoded check for `session.id` (redwoodjs#10013) Spelling fix in what-is-redwood.md (redwoodjs#10011) Typos in realtime.md (redwoodjs#10010) RSC: Server cell smoke tests (redwoodjs#10008) RSC: test-project EmptyUser 'use client' cell (redwoodjs#10007) RSC: babel-plugin-redwood-cell remove redundant reset (redwoodjs#10006) chore(deps): Upgrade to yarn v4.1.0 (redwoodjs#10002) fix(docs): Spelling of `data-migrate` command (redwoodjs#10003) docs: add aliases fo `type-check` command (redwoodjs#10004) RSC: Insert 'use client' in scaffolded components (redwoodjs#9998) fix(telemetry): Fix 'destroy' spelling (redwoodjs#10000) chore(jsdocs): Fix jsdoc formatting for hover help (redwoodjs#9999) bug: Update setupHandler.ts firebase version (redwoodjs#9997) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug when User table had a primary key other than
id. Shout out to @will-ks for finding this!Impact
For apps which had a primary key other than
id, all users will be logged out on their next request after this is deployed.Not sure if we consider that breaking? But it is 7.0 so anything goes!
Closes #10005