Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adds GraphQL Caching docs for Client and Response caching #10054

Merged
merged 9 commits into from
May 8, 2024

Conversation

dthyresson
Copy link
Contributor

When v7 documentation was deployed, somehow the useCache hook documentation for interacting with the Apollo Client cache was omitted (or I lost it).

This PR Adds a Caching sidebar to the GraphQL documentation to cover both client and server (aka response) caching.

image

@dthyresson dthyresson added the release:docs This PR only updates docs label Feb 22, 2024
@dthyresson dthyresson self-assigned this Feb 22, 2024
@jtoar
Copy link
Contributor

jtoar commented Feb 22, 2024

@dthyresson looking good just pushed up a few fixes.

I just saw that it seems like some of this content is duplicated between here and another GraphQL docs:

### useCache

(On the docs site, https://redwoodjs.com/docs/graphql#usecache.) Does that shed any light on what happened?

Also what should we do about the header in the GraphQL fragments doc? Link to these?

## useCache!!!

@jtoar jtoar added this to the next-release-patch milestone Feb 22, 2024
@dthyresson
Copy link
Contributor Author

Also what should we do about the header in the GraphQL fragments doc? Link to these?

Good point. I missed that. I added a note and link to the identify and caching does to explain a bit more what the cache keys are.

@dthyresson dthyresson mentioned this pull request May 7, 2024
1 task
@dthyresson dthyresson linked an issue May 7, 2024 that may be closed by this pull request
1 task
@dthyresson dthyresson requested review from Josh-Walker-GM and removed request for jtoar May 7, 2024 17:01
@Josh-Walker-GM Josh-Walker-GM merged commit 1f5638e into main May 8, 2024
46 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the dt-doc-use-cache branch May 8, 2024 09:32
Josh-Walker-GM added a commit that referenced this pull request May 8, 2024
When v7 documentation was deployed, somehow the `useCache` hook
documentation for interacting with the Apollo Client cache was omitted
(or I lost it).

This PR Adds a Caching sidebar to the GraphQL documentation to cover
both client and server (aka response) caching.


![image](https://github.com/redwoodjs/redwood/assets/1051633/90036d5a-934a-4be8-93b6-d79a876e9348)

---------

Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
Josh-Walker-GM added a commit that referenced this pull request May 8, 2024
When v7 documentation was deployed, somehow the `useCache` hook
documentation for interacting with the Apollo Client cache was omitted
(or I lost it).

This PR Adds a Caching sidebar to the GraphQL documentation to cover
both client and server (aka response) caching.


![image](https://github.com/redwoodjs/redwood/assets/1051633/90036d5a-934a-4be8-93b6-d79a876e9348)

---------

Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
@Josh-Walker-GM Josh-Walker-GM modified the milestones: next-release, v7.5.0 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: useCache!!!
3 participants