Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsdoc for ScenarioData type #10066

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Update jsdoc for ScenarioData type #10066

merged 3 commits into from
Feb 27, 2024

Conversation

c-ciobanu
Copy link
Contributor

The indentation of the example scenario in the JSDoc for the ScenarioData type is wrong making it hard to read, this PR fixes that.

@Tobbe
Copy link
Member

Tobbe commented Feb 26, 2024

Thanks for your PR @c-ciobanu
I noticed that the other JSDocs in this file also look a little malformed. Do you think you could fix all of them while you're at it? Thanks!

@Tobbe Tobbe added the release:fix This PR is a fix label Feb 26, 2024
@Tobbe Tobbe added this to the next-release milestone Feb 26, 2024
@c-ciobanu
Copy link
Contributor Author

Sure, fixed it all.

@Tobbe Tobbe enabled auto-merge (squash) February 26, 2024 16:06
@Tobbe Tobbe disabled auto-merge February 26, 2024 16:06
@Tobbe Tobbe merged commit 7e179ee into redwoodjs:main Feb 27, 2024
41 checks passed
@Tobbe
Copy link
Member

Tobbe commented Feb 27, 2024

Thanks again for the PR @c-ciobanu!

dac09 added a commit to dac09/redwood that referenced this pull request Feb 27, 2024
…onsolidate-vite-settings-rsc-builds

* 'feat/rsc-build' of github.com:dac09/redwood:
  Update jsdoc for ScenarioData type (redwoodjs#10066)
  fix(deps): update opentelemetry-js monorepo (redwoodjs#10065)
  @tobbe.dev/rsc-test@0.0.5
  @tobbe.dev/rsc-test@0.0.4
@c-ciobanu c-ciobanu deleted the jsdoc-fix-scenario-data branch February 27, 2024 08:34
jtoar pushed a commit that referenced this pull request Feb 27, 2024
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
jtoar pushed a commit that referenced this pull request Feb 28, 2024
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
jtoar pushed a commit that referenced this pull request Feb 28, 2024
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
@jtoar jtoar modified the milestones: next-release-patch, v7.0.4 Feb 28, 2024
jtoar pushed a commit that referenced this pull request Feb 28, 2024
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
@jtoar jtoar modified the milestones: v7.0.4, next-release-patch Feb 28, 2024
jtoar pushed a commit that referenced this pull request Feb 28, 2024
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
@jtoar jtoar modified the milestones: next-release-patch, v7.0.4 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants