fix(esm): get lint working #10152
Merged
fix(esm): get lint working #10152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
force-pushed
the
ds-esm/get-lint-working
branch
from
bfb632d
to
c1d7ec7
Compare
jtoar
added
fixture-ok
jtoar
added a commit
that referenced
this pull request
Mar 9, 2024
Started this PR so that an ESM project could run `yarn rw lint` (right now you'd get the following error: ``` Oops! Something went wrong! :( ESLint: 8.55.0 Error [ERR_REQUIRE_ESM]: require() of ES Module ~/redwood-app/prettier.config.js from ~/redwood-app/node_modules/prettier/third-party.js not supported. Instead change the require of prettier.config.js in ~/redwood-app/node_modules/prettier/third-party.js to a dynamic import() which is available in all CommonJS modules. ``` ) but didn't quite fix that yet—that seems to require Prettier v3 which may be possible to release in a minor thanks to @Josh-Walker-GM's efforts porting us over to Vitest! While this PR doesn't get `yarn rw lint` working, it does get a bunch of generators and setup commands working that use Prettier since they were using `require` to import the prettier config file. --------- Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started this PR so that an ESM project could run
yarn rw lint(right now you'd get the following error:) but didn't quite fix that yet—that seems to require Prettier v3 which may be possible to release in a minor thanks to @Josh-Walker-GM's efforts porting us over to Vitest!
While this PR doesn't get
yarn rw lintworking, it does get a bunch of generators and setup commands working that use Prettier since they were usingrequireto import the prettier config file.