docs(router): NavLink wording improvements #10380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added
release:docs
jtoar
approved these changes
Apr 2, 2024
docs/docs/router.md
Outdated
| <!-- When match "/" --> | ||
| <!-- Will match "/" --> |
There was a problem hiding this comment.
The original wasn't clear, but I think the spirit of it is lost if we replace it with just "will". I think "when" was supposed to be short for something like adds "activeLink" when the URL matches "/". Maybe we could do will add "activeLink" when the URL matches "/"?
There was a problem hiding this comment.
I wanted to keep as close as possible to the existing docs, just make them easier to read and understand.
With that in mind I like your first suggestion best. It's probably more inline with what the original author wanted to express. So I'll go with that for this PR.
That said, it's actually wrong now. But I'll get this merged, and then follow up with a different PR that explains what I mean.
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Apr 2, 2024
…nto feat/register-middleware * 'feat/register-middleware' of github.com:dac09/redwood: docs(router): NavLink wording improvements (redwoodjs#10380)
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Apr 2, 2024
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying to improve the wording in our docs to make them easier to read and understand