feat(baremetal): Add verbose output to ssh exec #10525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Yeah I’d just make that the default error output! |
Cool. I'll just make this PR about adding verbose output to Separate PR: #10527 |
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Apr 30, 2024
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 1, 2024
…e-middleware-client * 'main' of github.com:redwoodjs/redwood: chore(server-auth): Automagic middleware auth on supported providers (dbAuth so far) (redwoodjs#10529) feat(baremetal): Add more details to error messages (redwoodjs#10527) feat(baremetal): Add verbose output to ssh exec (redwoodjs#10525) Fix typos in seo-head (`<Metadata />`) docs (redwoodjs#10526) chore(cli): Wrap NodeSSH to make sshExec an instance method (redwoodjs#10524) Fix broken Azure / MSAL documentation links (redwoodjs#10505) chore(deps): Stop using PR build of rehackt - use proper version (redwoodjs#10523) feat(og-gen): Implement middleware and hooks (redwoodjs#10469) RSC: Rename RSC CI test case (redwoodjs#10521) feat(eslint): Disable restricted $api imports for entryserver (redwoodjs#10520) RSC: Add RSC+SSR smoke test to CI (redwoodjs#10477) fix(dbauth-mw): Use response passed in to middleware (redwoodjs#10516)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
--verboseto the baremetal deploy command is supposed to give you more detailed info about what's happening. Previously however passing--verbosedidn't actually provide any extra information. This PR adds logging to the new SshExecutor class so that you can see exactly what SSH commands are being run, and in what path.Standard output (this stays the same before and after)
Before (verbose output)
Doesn't really help much compared to the standard output 😅
After (verbose output)