chore(canary): Avoid workspace:* in published package.json files
#10532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:chore
|
Merging this right in was a reasonable way to test it actually worked. It appears to have done so - the published |
dac09
added a commit
that referenced
this pull request
May 2, 2024
…auth-reauthenticate-refactor * 'main' of github.com:redwoodjs/redwood: chore(canary): Avoid `workspace:*` in published package.json files (#10532)
Josh-Walker-GM
added a commit
that referenced
this pull request
May 2, 2024
…10532) **Problem** It appears leaving these `workspace:*` values in for peer dependencies can result in: ``` ➤ YN0001: │ TypeError: Cannot read properties of null (reading 'set') ``` This was happening to me today. We can simply replace these with the canary version we are publishing. We already avoid `workspace:*` in our stable releases. **Changes** Updates the existing shell script to also replace all occurrences of `workspace:*` with the canary version.
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 2, 2024
…e-middleware-client * 'main' of github.com:redwoodjs/redwood: chore(canary): Avoid `workspace:*` in published package.json files (redwoodjs#10532)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It appears leaving these
workspace:*values in for peer dependencies can result in:This was happening to me today. We can simply replace these with the canary version we are publishing.
We already avoid
workspace:*in our stable releases.Changes
Updates the existing shell script to also replace all occurrences of
workspace:*with the canary version.