fix(cli): Add deprecation notice for edgio deployment #10551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterp
approved these changes
May 11, 2024
|
Thank you for doing this 🚀 |
|
@Josh-Walker-GM one reminder and future to-do: Before we chose to fully remove this in the next major, we should communicate with the Edg.io team to see if they would like to pick-up support. If they do, we could make a handoff so users have an alternative. Most of all, I just don't want them to be surprised. For those curious as to why this deprecation is being added:
|
dac09
added a commit
that referenced
this pull request
May 15, 2024
…uth-store * 'main' of github.com:redwoodjs/redwood: chore(router): Add more code comments to analyzeRoutes (#10569) RSC: No need to use memo or useMemo in the server router (#10568) RSC: getViteConfig in rscWorker (#10567) Split RSC and RSA handling in rscWorker (#10565) RSC: Extract the fetchRSC function (#10564) RSC: Fix TODO regarding SSR in client.ts (#10562) Docs: QoL Updates to Contributing.md (#10561) Added warning note to not add WebAuthn (#10231) fix(rsc): Load all css links to support css with rsc (#10544) fix(cli): Add deprecation notice for edgio deployment (#10551) Define `process.env.NODE_ENV` in build process. (#10553) chore(docs): Update dbAuth and Supabase middleware READMEs (#10552) chore(deps): Upgrade React 19 to beta 20240508 (#10560) Revert "chore(deps): React beta 20240508 (#10558)" (#10559) chore(deps): React beta 20240508 (#10558) fix(functions): Fix context variable warning/error (#10556) fix(functions): Mock context in function test template (#10555) chore(middleware): Format code and comments and fix comment grammar (#10554)
Josh-Walker-GM
added a commit
that referenced
this pull request
May 15, 2024
**Changes** 1. Adds a deprecation notice to the cli for the setup and deploy commands for the edgio deployment provider. 2. Adds a deprecation notice to the edgio deployment documentation. **Notes** 1. On the documentation change: I didn't explicitly create a forum post to provide insight into this decision instead I simply asked anyone who has input to do so. 2. I used both the yargs `deprecated` config and also used the same style of adding `DEPRECATED` to the setup command description that had been used for the serverless deploy deprecation notice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Notes
deprecatedconfig and also used the same style of addingDEPRECATEDto the setup command description that had been used for the serverless deploy deprecation notice.