fix(cli): Handle case for no arguments for verbose baremetal deploy #10663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not explicitly tested but this should close #10654 🤞 |
1 task
Tobbe
reviewed
May 21, 2024
Tobbe
reviewed
May 21, 2024
Tobbe
reviewed
May 21, 2024
Tobbe
reviewed
May 21, 2024
|
Thanks @Tobbe, a lot simpler/cleaner now! |
Josh-Walker-GM
added a commit
that referenced
this pull request
May 22, 2024
…10663) **Problem** We recently improved the verbose output of the baremetal deployment process. It looks like this improvement has introduced a small bug. See #10654 for more details. **Changes** 1. Guard against `args` being undefined. --------- Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Josh-Walker-GM
added a commit
that referenced
this pull request
May 22, 2024
…10663) **Problem** We recently improved the verbose output of the baremetal deployment process. It looks like this improvement has introduced a small bug. See #10654 for more details. **Changes** 1. Guard against `args` being undefined. --------- Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 22, 2024
…-role-authmw * 'main' of github.com:redwoodjs/redwood: fix(dbAuthMw): Update and fix logic related to dbAuth "verbs" and decryptionErrors (redwoodjs#10668) RSC: routes-auto-loader is not used for SSR anymore (redwoodjs#10672) chore(crwa): Remove unused jest dev dependency (redwoodjs#10673) RSC: rscBuildEntriesFile: Only ServerEntry and Routes needed for serverEntries (redwoodjs#10671) RSC: clientSsr: getServerEntryComponent() (redwoodjs#10670) RSC: worker: getFunctionComponent -> getRoutesComponent (redwoodjs#10669) RSC: kitchen-sink: Make the ReadFileServerCell output take up less space (redwoodjs#10667) RSC: Remove commented code related to prefixToRemove transform() (redwoodjs#10666) RSC Client Router (redwoodjs#10557) RSC: Add 'use client' to remaining client cells in kitchen-sink (redwoodjs#10665) RSC: vite auto-loader: Spell out 'path' and other chores (redwoodjs#10662) fix(cli): Handle case for no arguments for verbose baremetal deploy (redwoodjs#10663) RSC: kitchen-sink: Make it more clear where layout ends and main content starts (redwoodjs#10661) RSC: Make the kitchen-sink smoke-test more robust/resilient (redwoodjs#10660) RSC: Source format of EmptyUsersCell in kitchen-sink (redwoodjs#10658) RSC: Add 'use client' to all client cells in kitchen-sink (redwoodjs#10659) chore(__fixtures__): Follow-up: Make test projects match newer CRWA template (redwoodjs#10657) feat: Reworks RSC server entries and route manifest building to derive from routes and include if route info related to authentication (redwoodjs#10572) chore(__fixtures__): Make test projects match newer CRWA template (redwoodjs#10655)
Josh-Walker-GM
added a commit
that referenced
this pull request
May 22, 2024
**Problem** We introduced an error in the fix here: #10663 **Changes** 1. We ensure a space is present in the built command.
Josh-Walker-GM
added a commit
that referenced
this pull request
May 22, 2024
**Problem** We introduced an error in the fix here: #10663 **Changes** 1. We ensure a space is present in the built command.
Josh-Walker-GM
added a commit
that referenced
this pull request
May 22, 2024
**Problem** We introduced an error in the fix here: #10663 **Changes** 1. We ensure a space is present in the built command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We recently improved the verbose output of the baremetal deployment process. It looks like this improvement has introduced a small bug. See #10654 for more details.
Changes
argsbeing undefined.