fix cell generated test template

[thedavidprice]

@peterp looping you in on this one. Dom and I are coordinating the generated tests that need to be fixed/completed. This seemed to do the trick for cells but would welcome your eyes/improvement.

[thedavidprice]

Looking further, I found this original Cell test template sketch:
#629

Now looking into using the mock file to do something closer to ^^

[thedavidprice]

closes #629

[thedavidprice]

@peterp This one is ready for review -- any suggests about other/better ways to incorporate the existing mock file into the tests? Also, I took some notes from Robert for specific Jest queries used. Please confirm that's what you'd like to see in the template.

[RobertBroersma]

Hey @thedavidprice

Rendering the individual parts of a cell is kind of testing implementation details. What I would love to see is something more like in #629, but with MSW instead of MockedProvider

Something like this:

import { render, screen, graphql } from '@redwoodjs/testing'

import BlogPostCell from './BlogPostCell'

describe('BlogPostCell', () => {
  it('renders post succesfully', async () => {
    graphql.query('GetPost', (req, res, ctx) => {
      return res(
        ctx.data({
          post: {
            title: 'Post Title',
            id: 'id-123',
            body: 'Test',
            __typename: 'Post',
          },
        })
      )
    })

    render(<BlogPostCell id="id-123" />)

    expect(await screen.findByText(/Post Title/)).toBeInTheDocument()
  })

  it('handles errors', async () => {
    graphql.query('GetPost', (req, res, ctx) => {
      return res(
        ctx.errors([
          {
            message: 'Whoops!',
          },
        ])
      )
    })

    render(<BlogPostCell id={1} />)

    expect(await screen.findByText(/Whoops!/)).toBeInTheDocument()
  })
})

I'm not so familiar with the generator outputs, so I'm not sure if this is possible, but I think it is!

This way the test is closer to the real world use of BlogPostCell. The user will after all be using <BlogPostCell /> and not the individual parts of the cell.

Does that make sense?

Let me know if you'd like me to take a stab at writing the generator template!

[peterp]

I think @RobertBroersma's suggestion make sense, but this pull-request may have been focusing on fixing the test templates. Maybe we should open another issue for improving them?

[RobertBroersma]

@peterp Oh my bad, I didn't realize it was broken! I think the new issue you're describing is #629 . I'll put my snippet there.

All good here then!