improve(cli): Add validation for tag supplied to rw upgrade #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dac09 this is working very well! I made a comment about adding the "latest" tag as allowed. Also, this is a minor issue if easy to address --> The error is given twice "Invalid tag supplied. Supported values: rc, canary or valid semver version". Possible to remove duplicate?
|
|
Sure @thedavidprice I'll try and figure out why that happens, but isn't super obvious! |
Co-authored-by: David Price <thedavid@thedavidprice.com>
|
This is working great! Andy easy fix on the error output redundancy. Here's the updated output on Error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1270
The tag is now validated to be
rc,canaryor any valid semver string.Regex comes from https://github.com/sindresorhus/semver-regex#readme