Replaced merge-graphql-schemas with graphql-tools

[himankpathak]

Description

Replaced mergeType from merge-graphql-schemas with mergeTypeDefs graphql-tools

Verification Process

Tested on local with prebuilt tests

Applicable Issues

Closes #1230

[thedavidprice]

Awesome, thanks for getting this rolling @himankpathak 🚀

Handing you off to @peterp from here out.

[peterp]

@himankpathak I'm surprised that the tests are working locally since this doesn't seem to be building properly. Perhaps I over estimated the coverage that we have.

[himankpathak]

@peterp, I am surprised too. Locally test passed. But on PR the build is failing.

[Urigo]

Just a small note - if you want to use the new GraphQL Tools, you better install the scoped packages, so you'll get only the parts of graphql-tools that you need

[peterp]

Hey @himankpathak

It looks like it's the same issue as before - I'll check out your branch in a few minutes and figure this out.

[himankpathak]

That would be great! @peterp

[thedavidprice]

@peterp is this PR + work still relevant. If so, @himankpathak are you still interested in working on this?

Thanks to you both!

[himankpathak]

@thedavidprice definitely!
I will resolve the conflicts and see if we sort the failing tests.

[peterp]

Thanks @himankpathak!

[himankpathak]

Test cases are passing on local

We have following error on packages/api/src/makeMergedSchema/makeMergedSchema.ts L167

No overload matches this call.
  Overload 1 of 3, '(types: (string | GraphQLSchema | Source | DocumentNode)[], config?: (Partial<Config> & { commentDescriptions: true; }) | undefined): string', gave the following error.
    Type 'Record<string, unknown>' is not assignable to type 'string | GraphQLSchema | Source | DocumentNode'.
      Type 'Record<string, unknown>' is not assignable to type 'string'.
  Overload 2 of 3, '(types: (string | GraphQLSchema | Source | DocumentNode)[], config?: Pick<Partial<Config>, "useSchemaDefinition" | "forceSchemaDefinition" | ... 4 more ... | "convertExtensions"> | undefined): DocumentNode', gave the following error.
    Type 'Record<string, unknown>' is not assignable to type 'string | GraphQLSchema | Source | DocumentNode'.
      Type 'Record<string, unknown>' is not assignable to type 'string'.ts(2769)

[github-actions]

📦 PR Packages

Click to Show Package Download Links

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/create-redwood-app-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-api-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-api-server-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-auth-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-cli-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-core-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-dev-server-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-eslint-config-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-eslint-plugin-redwood-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-forms-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-internal-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-router-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-structure-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-testing-0.23.0-7e03dfc.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1322/redwoodjs-web-0.23.0-7e03dfc.tgz

Install this PR by running yarn rw upgrade --pr 1322:0.23.0-7e03dfc

[thedavidprice]

@peterp I just pushed code from the Migration from Merge GraphQL Schemas guide that proxies mergeTypes to mergeTypeDefs. There was an API change — this solution was an, ahem, efficient step forward although I'm sure it could be condensed.

Tested on my local project and everything is working fine (note the need to account for this change to test a project). Tests passed locally.

[peterp]

Looks good to me!

[peterp]

Before we release v0.24.0 I would like to try this out in Snaplet.