Fix storybook on Windows #1324
Merged
Fix storybook on Windows #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tobbe You legend! Well done! |
peterp
approved these changes
Oct 10, 2020
|
@peterp Can you please try this on MacOS? Especially with a path with spaces in it. |
|
aahhhhhhhh yeaaaaaahhhhhhh @Tobbe 🚀 |
|
@Tobbe I don't think it'll be a problem, since it's meant to be a glob, but I'll verify that it's working before we release a new version. |
|
Thanks for this fix @Tobbe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #954
I've verified that it works on Windows GitBash, Windows PowerShell and Windows Cmd
Can someone else please check that I didn't break it for MacOS/Linux? I'm especially worried about path with spaces on *nix