Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1256 router "Create Page..." codelens positon #1326

Merged

Conversation

mbucchi
Copy link
Contributor

@mbucchi mbucchi commented Oct 11, 2020

Fixes #1256 by modifying the location in which the codelens is rendered. It used to be rendered above the first route and now is rendered on top of the <Router> tag instead.
image
This also allows for further changes within the structure of router without disrupting the codelens.

Copy link
Contributor

@aldonline aldonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok.
It just removes an "if" block. It fixes the issue and, as @mbucchi says, it is more robust since it will work in any scenario, as long as the <Router> tag is present.

@mbucchi if this gets merged, you can tell the world that you removed an if block in Redwood. Major accomplishment ;)

@thedavidprice
Copy link
Contributor

Ha! It's good to go if you say it is @aldonline

Thanks for the PR @mbucchi! For the record, my favorite PRs are those where lines remove > lines added 😆

@thedavidprice
Copy link
Contributor

wait a second....

BROTHERS

😆

@mbucchi
Copy link
Contributor Author

mbucchi commented Oct 14, 2020

😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Create Page" CodeLens in wrong position when first element in <Router> is <Private>
4 participants