Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VS Code private icon logic #1331

Merged
merged 5 commits into from
Oct 14, 2020

Conversation

M0nica
Copy link
Contributor

@M0nica M0nica commented Oct 12, 2020

This branch was branched off of: #1325

This is what I see in VSCode for my test app (example-todo) with a private route when running my redwood changes locally:
Screen Shot 2020-10-12 at 2 28 24 PM

@thedavidprice
Copy link
Contributor

Thanks @M0nica! Labeled and looped in Aldo via Assignment.

I wasn't sure how to test this locally...

^^ Ah, great question. @aldonline I'm curious as well if it's even possible to locally test things VS Code Extension specific... recommendations for workarounds until the codebase is open? (Which, to be clear, is not a subtle nudge to hurry up or reprioritize 馃槅)

@aldonline
Copy link
Contributor

Hi @M0nica,

  1. Please uninstall Decoupled Studio and install the Redwood IDE. This is the official extension moving forward. We will eventually make it completely opensource and move it into the redwoodjs/redwood monorepo
  2. When the extension is activated, it will look for node_modules/@redwoodjs/structure/dist/language_server/start.js and use it to start a language server process in the background. This means that most of the features that you see in VSCode will come from code that is installed alongside the Redwood framework (in the structure package, which is what you're editing right now). In other words, you should be able to use the same workflow described in CONTRIBUTING.md ex: (yarn rwt copy:watch). Just make sure to restart VSCode whenever you make a change so the extension starts a language server with the updated code.

Notes to self:

  • Remove all Redwood functionality from Decoupled Studio. Show a warning and a link to the Redwood IDE
  • Add a CONTRIBUTING.md file to the structure package

@M0nica M0nica marked this pull request as ready for review October 13, 2020 22:06
@thedavidprice
Copy link
Contributor

@aldonline Ah, super helpful instructions. And, yes, please do add Contributing info to the package Readme. And/or let me know how I can help.

This one looks ready for review. Let me know when it's ready and I鈥檒l get it merged.

Thanks, all!

@thedavidprice
Copy link
Contributor

Thanks, all 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants