-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VS Code private icon logic #1331
Update VS Code private icon logic #1331
Conversation
Thanks @M0nica! Labeled and looped in Aldo via Assignment.
^^ Ah, great question. @aldonline I'm curious as well if it's even possible to locally test things VS Code Extension specific... recommendations for workarounds until the codebase is open? (Which, to be clear, is not a subtle nudge to hurry up or reprioritize 馃槅) |
Hi @M0nica,
Notes to self:
|
@aldonline Ah, super helpful instructions. And, yes, please do add Contributing info to the package Readme. And/or let me know how I can help. This one looks ready for review. Let me know when it's ready and I鈥檒l get it merged. Thanks, all! |
Thanks, all 馃殌 |
redwood
however I did not see any changes to the VSCode outline when I made these changes. I've installed https://marketplace.visualstudio.com/items?itemName=decoupled.studio but I am not seeing the gist icon or the private-gist icon for page files 馃This branch was branched off of: #1325
This is what I see in VSCode for my test app (example-todo) with a private route when running my redwood changes locally:
![Screen Shot 2020-10-12 at 2 28 24 PM](https://user-images.githubusercontent.com/6998954/95778983-3133b780-0c97-11eb-8a2c-1aa0ce4fd23a.png)