fix(web): Fix importing .ts/.tsx files in web with directory-named-import plugin #1332
Conversation
| @@ -9,7 +10,16 @@ const getNewPath = (value: string, filename: string) => { | |||
| const newImportPath = [dirname, basename, basename].join('/') | |||
|
|
|||
| try { | |||
There was a problem hiding this comment.
Since resolveFile returns null when the path isn't found, I think we can remove the try/catch blocks.
| try { | |
| return resolveFile(path.join(path.dirname(filename), newImportPath)) |
|
oooh, 🦜🦆 with 🗻 |
|
Note: there is one failing test EDIT: done |
|
Oh windows! |
|
I think @Tobbe contributed an utility called |
Giving that a go now 👍 |
dac09
force-pushed
the
fix/ts-imports-web
branch
from
44e11ec
to
cf087ad
Compare
|
@peterp ready for review. Finally got them windows paths! ✅ |
| @@ -35,7 +43,7 @@ export default function ({ types: t }: { types: typeof types }): PluginObj { | |||
|
|
|||
| const newPath = getNewPath(value, <string>filename) | |||
| if (!newPath) return | |||
| const newSource = t.stringLiteral(value.replace(value, newPath)) | |||
| const newSource = t.stringLiteral(ensurePosixPath(newPath)) | |||
| { | ||
| input: 'import pew from "./__fixtures__/directory-named-imports/Module"', | ||
| output: | ||
| 'import pew from "./__fixtures__/directory-named-imports/Module/Module"', | ||
| output: `import pew from "${POSIX_DIRNAME}/__fixtures__/directory-named-imports/Module/Module.js";`, |
There was a problem hiding this comment.
Had a thought. Something feels off here, because imports in NodeJS are always in unix style. I guess it's because of the way that we get the absolute paths.
There was a problem hiding this comment.
Not exactly happy with this. There's nothing actionable, just thought I would mention it.
|
THanks <3! |
As title :)
Resolves #1290
Resolves #1214
todo