Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix directory named imports #1364

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Fix directory named imports #1364

merged 3 commits into from
Oct 15, 2020

Conversation

peterp
Copy link
Contributor

@peterp peterp commented Oct 15, 2020

This PR uses a relative path to test if a module exists, but then returns an import-type path for for importing the module.

@peterp peterp requested review from dac09 and Tobbe October 15, 2020 19:56
@dac09
Copy link
Collaborator

dac09 commented Oct 15, 2020 •
edited
Loading

Can't test as AFK, but code looks good to me!

@peterp peterp merged commit 5444152 into main Oct 15, 2020
@thedavidprice thedavidprice added this to the Next release milestone Oct 15, 2020
@thedavidprice thedavidprice deleted the pp-fix-dirname-babel-imports branch October 15, 2020 20:51
@thedavidprice thedavidprice mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dac09 dac09 dac09 approved these changes

@Tobbe Tobbe Awaiting requested review from Tobbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterp @dac09 @thedavidprice